Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rsources tests - postgres resources use different creds #3919

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Sep 27, 2023

Description

use unique(rand.String) credentials(db name, username, password) for each postgres resources spawned.

Linear Ticket

slack thread

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (890ca68) 69.21% compared to head (c0e72f3) 69.22%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3919      +/-   ##
==========================================
+ Coverage   69.21%   69.22%   +0.01%     
==========================================
  Files         357      357              
  Lines       53145    53145              
==========================================
+ Hits        36784    36790       +6     
+ Misses      14046    14043       -3     
+ Partials     2315     2312       -3     
Files Coverage Δ
services/rsources/handler.go 74.65% <100.00%> (-0.56%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth force-pushed the chore.rSourcesTestsPostgresResource branch from 09bfd67 to c0e72f3 Compare September 28, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants