fix: use dedup on new records for deltalake #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
approved these changes
Sep 28, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/1.14.x #3927 +/- ##
===============================================
Coverage 68.88% 68.88%
===============================================
Files 351 351
Lines 52697 52700 +3
===============================================
+ Hits 36300 36305 +5
+ Misses 14084 14081 -3
- Partials 2313 2314 +1
☔ View full report in Codecov by Sentry. |
achettyiitr
force-pushed
the
fix.deltalake-etl-dedup
branch
from
29d0231 to
b47d7b0
Compare
achettyiitr
commented
Sep 29, 2023
Comment on lines
+902
to
+904
| if d.Uploader.ShouldOnDedupUseNewRecord() { | ||
| return "", nil | ||
| } |
There was a problem hiding this comment.
Since the changes are straightforward, going forward with the changes. Also, I have captured the test here since it was easy for me to add it there.
Merged
1 task
This was referenced Oct 9, 2023
Closed
This was referenced Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Security