-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use GCSUploadIfNotExist setting for file manager #4716
base: master
Are you sure you want to change the base?
Conversation
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Removed uuid from file names prepared by archiver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you handle ErrPreConditionFailed
?
Can we add test case as well ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4716 +/- ##
==========================================
+ Coverage 74.60% 74.71% +0.10%
==========================================
Files 414 414
Lines 48546 48558 +12
==========================================
+ Hits 36220 36281 +61
+ Misses 9954 9920 -34
+ Partials 2372 2357 -15 ☔ View full report in Codecov by Sentry. |
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Description
Update file manager to use new
GCSUploadIfNotExist
setting. Will avoid the gcs storage overwrite related issues.Users of this filemanager:
Both of them are fit to use this setting.
Linear Ticket
Resolves PIPE-1072
Security