Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove legacy hosted code which changes connectionToken #5126

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Sep 23, 2024

Description

Fixes PIPE-1470
remove legacy hosted code which changes connectionToken
Related to https://github.com/rudderlabs/cp-router/pull/200

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1470/choose-primary-namespace-for-cp-router-connection-for-warehouse

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@BonapartePC BonapartePC requested a review from cisse21 September 23, 2024 10:48
@ktgowtham ktgowtham self-requested a review September 23, 2024 11:11
@BonapartePC BonapartePC enabled auto-merge (squash) September 26, 2024 06:23
@BonapartePC BonapartePC merged commit 100b3d9 into master Sep 26, 2024
54 checks passed
@BonapartePC BonapartePC deleted the fix.removeLegacyHostedCode branch September 26, 2024 07:57
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.06%. Comparing base (33b5f63) to head (e9f3a12).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5126      +/-   ##
==========================================
- Coverage   73.06%   73.06%   -0.01%     
==========================================
  Files         437      437              
  Lines       50789    50787       -2     
==========================================
- Hits        37110    37108       -2     
+ Misses      11260    11258       -2     
- Partials     2419     2421       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants