chore: webhook v0 deprecation while defaulting to v1 #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
reviewed
Oct 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5187 +/- ##
==========================================
+ Coverage 73.18% 73.23% +0.04%
==========================================
Files 417 417
Lines 59532 59532
==========================================
+ Hits 43568 43596 +28
+ Misses 13523 13505 -18
+ Partials 2441 2431 -10 ☔ View full report in Codecov by Sentry. |
vinayteki95
force-pushed
the
chore.webhook-v0-deprecation
branch
from
4eafac3 to
eca8619
Compare
vinayteki95
force-pushed
the
chore.webhook-v0-deprecation
branch
from
eca8619 to
af19ce4
Compare
koladilip
approved these changes
Oct 14, 2024
| require.Nil(t, err) | ||
| }) | ||
| } | ||
| // t.Run("should return the right url", func(t *testing.T) { |
There was a problem hiding this comment.
don't keep commented code, we can always get back from git history
ktgowtham
approved these changes
Oct 24, 2024
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecation of webhook transformer service v0 adapter as a preliminary step to move towards v2 spec.
This is stage 0 of 3 for v2 spec upgrade.
Details regarding this upgrade can be found in this notion doc
Linear Ticket
Corresponding linear ticket can be found here.
Resolves INT-2754
Note:
This will be a breaking change for older rudder-transformer versions. (older than 1.50.0 rudder-transformer)