Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse error due incrorrect csv response from marketo-n #5252

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Oct 30, 2024

Description

The issue is due to incorrect csv response from marketo, hence rather than reading all rows at once we are reading each row separately.

For the erroneous rows we cannot identify which particular job as we cant generate hash to get corresponding job id hence these specific ones will be marked as success (we need to figure out a long term solution for this though)
Screenshot 2024-10-30 at 7 19 48 PM

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.29%. Comparing base (07b6555) to head (967e4c0).
Report is 1 commits behind head on release/1.37.x.

Files with missing lines Patch % Lines
...stinationmanager/marketo-bulk-upload/apiService.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.37.x    #5252      +/-   ##
==================================================
+ Coverage           73.23%   73.29%   +0.06%     
==================================================
  Files                 424      424              
  Lines               59960    59967       +7     
==================================================
+ Hits                43909    43955      +46     
+ Misses              13590    13553      -37     
+ Partials             2461     2459       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

break
}
if err != nil {
m.logger.Error("Error in parsing csv response", err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is line number captured in err.Error() ?

@utsabc utsabc merged commit 76beb84 into release/1.37.x Nov 1, 2024
58 checks passed
@utsabc utsabc deleted the fix.marketo-bulk-upload-csv-parse branch November 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants