Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replay tracking plan bug #5389

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Dec 23, 2024

Description

This PR is to fix the issue in the replay flow for connections with tracking plan . We were generating the commonMetaData from the input struct and were also altering the metadata before the transformer call while the commonMetaData was generated post the transformer call resulting in incorrect metadata propogated downstream. This PR fixes this by generating the commonMetaData before the transformer call

Linear Ticket

Fixes PIPE-1813

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 marked this pull request as ready for review December 23, 2024 06:48
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.90%. Comparing base (abd2cdb) to head (a13a952).
Report is 1 commits behind head on release/1.39.x.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.39.x    #5389      +/-   ##
==================================================
+ Coverage           74.72%   74.90%   +0.18%     
==================================================
  Files                 437      437              
  Lines               61274    61273       -1     
==================================================
+ Hits                45784    45894     +110     
+ Misses              12950    12853      -97     
+ Partials             2540     2526      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests to verify the behaviour after the fix?

@cisse21 cisse21 force-pushed the fix.replayTPBugTicketSwap branch from ea0d242 to a13a952 Compare December 23, 2024 08:58
@cisse21
Copy link
Member Author

cisse21 commented Dec 23, 2024

@mihir20 It isn't that easy to add a test case for this scenario. Talked to Tejo and we would be adding this task to backlog, merging for now

@cisse21 cisse21 merged commit 74056f8 into release/1.39.x Dec 23, 2024
58 checks passed
@cisse21 cisse21 deleted the fix.replayTPBugTicketSwap branch December 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants