feat: sfmc v2 onboarding #4009
Open
feat: sfmc v2 onboarding #4009
+2,326
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
reviewed
Jan 30, 2025
| export const SUPPORTED_EVENT_TYPE = 'record'; | ||
| export const ACTION_TYPES = ['insert', 'delete', 'update']; | ||
| export const ENDPOINTS = { | ||
| GET_TOKEN: `auth.marketingcloudapis.com/v2/token`, |
There was a problem hiding this comment.
template strings are not required here
| let messageType = .message.type; | ||
| $.assertConfig(config.objectType, "Object type is not present. Aborting"); | ||
| $.assert(messageType, "Message Type is not present. Aborting message."); | ||
| $.assert(messageType.toLowerCase() === $.SUPPORTED_EVENT_TYPE, `Event type ${.message.type.toLowerCase()} is not supported. Aborting message.`); |
There was a problem hiding this comment.
Suggested change
| $.assert(messageType.toLowerCase() === $.SUPPORTED_EVENT_TYPE, `Event type ${.message.type.toLowerCase()} is not supported. Aborting message.`); | |
| $.assert(messageType.toLowerCase() === $.SUPPORTED_EVENT_TYPE, `Event type ${.message.type} is not supported. Aborting message.`); |
There was a problem hiding this comment.
Remove toLowerCase for error message it is not critical
| $.assert(messageType, "Message Type is not present. Aborting message."); | ||
| $.assert(messageType.toLowerCase() === $.SUPPORTED_EVENT_TYPE, `Event type ${.message.type.toLowerCase()} is not supported. Aborting message.`); | ||
| $.assert(.message.fields, "`fields` is not present. Aborting message."); | ||
| $.assert(.message.identifiers, "`identifiers` is not present inside properties. Aborting message."); |
There was a problem hiding this comment.
inside properties or message
Comment on lines
+51
to
+54
| const payload = { | ||
| values: .message.fields | ||
| } | ||
| payload |
There was a problem hiding this comment.
Suggested change
| const payload = { | |
| values: .message.fields | |
| } | |
| payload | |
| { | |
| values: .message.fields | |
| } |
Comment on lines
+130
to
+136
| '@_xmlns:s': 'http://www.w3.org/2003/05/soap-envelope', | ||
| '@_xmlns:a': 'http://schemas.xmlsoap.org/ws/2004/08/addressing', | ||
| '@_xmlns:u': | ||
| 'http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd', | ||
| 's:Body': { | ||
| '@_xmlns:xsi': 'http://www.w3.org/2001/XMLSchema-instance', | ||
| '@_xmlns:xsd': 'http://www.w3.org/2001/XMLSchema', |
| @@ -0,0 +1,650 @@ | |||
| export const contactTests = [ | |||
| { | |||
There was a problem hiding this comment.
trying to reduce code duplication in call test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this PR?
We are onboarding a new destination named sfmc v2
What is the related Linear task?
Resolves INT-3121
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.