-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: airship array handling #4011
Conversation
Allure Test reports for this run are available at: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4011 +/- ##
========================================
Coverage 91.00% 91.00%
========================================
Files 630 629 -1
Lines 32807 32820 +13
Branches 7782 7785 +3
========================================
+ Hits 29855 29867 +12
- Misses 2701 2734 +33
+ Partials 251 219 -32 ☔ View full report in Codecov by Sentry. |
- add test-cases for the same
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
as discussed add component test cases |
- add component test-cases
Allure Test reports for this run are available at: |
test/integrations/destinations/airship/processor/business.ts
Dismissed
Show dismissed
Hide dismissed
test/integrations/destinations/airship/processor/business.ts
Dismissed
Show dismissed
Hide dismissed
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
Allure Test reports for this run are available at: |
|
What are the changes introduced in this PR?
If we send this request to Airship, we are getting a failed response due to presence of
[\d]
in the request being sent to AirshipAirship destination supports sending JSON attributes while creating/updating attributes. We are trying to make use of this.
For anyone interested in sending JSON attributes, they would need to define
JSONAttributes
in integrationObject like below:We will convert this to below and send it Airship
What is the related Linear task?
Resolves INT-3156
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.