Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snowflake): support oauth authentication #236
feat(snowflake): support oauth authentication #236
Changes from 3 commits
78e3a6a
48b0a02
8443f76
f741e97
e1bd4b0
8046a84
aa9f9fd
1ceb550
9f90552
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented logs.
Check warning on line 66 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L45-L66
Check warning on line 69 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L68-L69
Check warning on line 90 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L89-L90
Check warning on line 97 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L93-L97
Check warning on line 102 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L100-L102
Check warning on line 106 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L105-L106
Check warning on line 111 in sqlconnect/internal/snowflake/config.go
sqlconnect/internal/snowflake/config.go#L110-L111