Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlaunch: --auth does not quote --keyFile parameter #830

Closed
stennie opened this issue Oct 23, 2020 · 1 comment
Closed

mlaunch: --auth does not quote --keyFile parameter #830

stennie opened this issue Oct 23, 2020 · 1 comment
Assignees
@stennie
Labels
bug improvement mlaunch
Milestone
1.7.0

Comments

@stennie
Copy link
Collaborator

stennie commented Oct 23, 2020 •
edited
Loading

Expected behavior

--keyFile (and all other mlaunch path params) should be supported for paths that include embedded spaces

Actual/current behavior

The --auth command adds an unquoted --keyFile value, so mlaunch will fail if the path contains embedded spaces:

can't start process, return code 1. tried to launch: "mongod" ...

Thanks to @tap1r for the bug report.

Steps to reproduce the actual/current behavior

$ mkdir -p "test spaces/data"
$ cd "test spaces"
$ echo "mysecretkey" > data/keyfile
$ mlaunch init --single --auth --keyFile data/keyfile
@stennie stennie added this to the 1.7.0 milestone Oct 23, 2020
@stennie stennie self-assigned this Oct 23, 2020
@stennie stennie removed their assignment Jan 18, 2021
@stennie stennie self-assigned this Nov 27, 2021
@stennie
Copy link
Collaborator Author

stennie commented Nov 27, 2021

--keyFile is correctly quoted when it appears by itself. It looks like the actual bug is an extra unquoted --keyFile added with the --auth param is also included.

@stennie stennie changed the title mlaunch: --keyfile value needs to be quoted for paths with embedded spaces mlaunch: --auth assumes --keyFile will not be provided Nov 27, 2021
@stennie stennie changed the title mlaunch: --auth assumes --keyFile will not be provided mlaunch: --auth does not quote --keyFile with embedded spaces in path Nov 27, 2021
@stennie stennie changed the title mlaunch: --auth does not quote --keyFile with embedded spaces in path mlaunch: --auth does not quote --keyFile parameter Nov 27, 2021
stennie added a commit to stennie/mtools that referenced this issue Nov 27, 2021
@stennie
Fix rueckstiess#830: mlaunch: --auth does not quote --keyFile parameter
15d850f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stennie stennie

Labels
bug improvement mlaunch
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
1 participant
@stennie