-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SSL parameters (#127) #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mlaunch init --help
now includes:
SSL Options:
--sslCAFile SSLCAFILE
Certificate Authority file for SSL
--sslCRLFile SSLCRLFILE
Certificate Revocation List file for SSL
--sslAllowInvalidHostnames
allow client and server certificates to provide non-
matching hostnames
--sslAllowInvalidCertificates
allow client or server connections with invalid
certificates
Server SSL Options:
--sslOnNormalPorts use ssl on configured ports
--sslMode {disabled,allowSSL,preferSSL,requireSSL}
set the SSL operation mode
--sslPEMKeyFile SSLPEMKEYFILE
PEM file for ssl
--sslPEMKeyPassword SSLPEMKEYPASSWORD
PEM file password
--sslClusterFile SSLCLUSTERFILE
key file for internal SSL authentication
--sslClusterPassword SSLCLUSTERPASSWORD
internal authentication key file password
--sslDisabledProtocols SSLDISABLEDPROTOCOLS
comma separated list of TLS protocols to disable
[TLS1_0,TLS1_1,TLS1_2]
--sslWeakCertificateValidation
allow client to connect without presenting a
certificate
--sslAllowConnectionsWithoutCertificates
allow client to connect without presenting a
certificate
--sslFIPSMode activate FIPS 140-2 mode
Client SSL Options:
--sslClientCertificate SSLCLIENTCERTIFICATE
client certificate file for ssl
--sslClientPEMKeyFile SSLCLIENTPEMKEYFILE
client PEM file for ssl
--sslClientPEMKeyPassword SSLCLIENTPEMKEYPASSWORD
client PEM file password
import sys | ||
import threading | ||
import time | ||
import warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the imports are changing, I'm taking the opportunity to fix their style.
@@ -369,7 +416,7 @@ def init(self): | |||
if first_init: | |||
# add shards | |||
mongos = sorted(self.get_tagged(['mongos'])) | |||
con = MongoConnection('localhost:%i'%mongos[0]) | |||
con = self.client('localhost:%i' % mongos[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the MongoConnection calls need SSL options so I'm refactoring.
Thanks for the PR Jessie. We've been looking forward to adding SSL support to I found a peculiar issue, though. It seems that
However, using
Could you confirm that you're seeing the same behaviour? Sorry I can't dig deeper into the cause at the moment, but I'll be happy to help you with this. Kevin |
Thanks for testing this! I added a commit that fixes the issue with "list". mlaunch hadn't been using the loaded SSL client parameters to connect to the servers and check them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.