Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some rendering issues (and crash on Windows) #588

Open
Toad06 opened this issue May 14, 2020 · 7 comments
Open

Some rendering issues (and crash on Windows) #588

Toad06 opened this issue May 14, 2020 · 7 comments
Labels
A-rendering Area: Rendering & Graphics

Comments

@Toad06
Copy link
Member

Toad06 commented May 14, 2020

There are some rendering issues within the attached file. Tested with the following nightly builds:

  • Web Extension: 2020-05-14
  • Windows: 2020-05-01 (it crashes as of 2020-05-03)

file.zip

1

At the top of the file, there is a white line which is completely opaque in Flash, but appears a bit transparent in Ruffle.

2

f1-2

3

f1-3

There's sometimes some kind of odd pixel interpolation here. The issue doesn't happen with canvas (only Windows and WebGL).

@Dinnerbone
Copy link
Contributor

Dinnerbone commented May 14, 2020

Confirmed the rendering issues - but I don't get a crash in latest master. Do you get any information about the crash? Does it freeze or close? Does it happen in the latest nightly? Is the crash in desktop or web or both?

@Toad06
Copy link
Member Author

Toad06 commented May 14, 2020

It's on the desktop only. Ruffle freezes, then Windows displays its "Ruffle has stopped working" message. The last nightly build that works is the one from 2020-05-01, it does not work in nightly 2020-05-03 and 2020-05-14.

I've tried with other files and they actually all crash with the same message:

thread 'main' panicked at "called 'Option::unwrap()' on a 'None' value", C:\Users\circleci\project\render\wgpu\src\lib.rs:122:23

I don't know if that can help (or if it's just my old computer 😅).

@Dinnerbone
Copy link
Contributor

That helps, thank you! I'll open a PR to fix that crash, but the issue is that Ruffle asked your computer for a graphics device and your computer said "I don't have any". That sucks and it's kinda weird.

What GPU and drivers do you have installed?

Dinnerbone added a commit to Dinnerbone/ruffle that referenced this issue May 14, 2020
@Toad06
Copy link
Member Author

Toad06 commented May 14, 2020

Thanks for the explanation!

NVIDIA GeForce GT 540M
Driver version: 21.21.13.7654

I've also quickly tested on another and more recent computer, it didn't freeze and crash but there was another issue with graphics being completely flipped:
flip

NVIDIA GeForce 940MX
Driver version: 21.21.13.7654

Intel HD Graphics 620
Driver version: 26.20.100.7263

I will try to update those and see if it changes anything.

@Herschel Herschel added the A-rendering Area: Rendering & Graphics label May 15, 2020
@Herschel
Copy link
Member

Herschel commented May 15, 2020

Issue 1, having trouble reproing, the white line is opaque for me? Maybe I'm misunderstanding.

Issue 2 is due to the "2000" image being overlaid using a blend mode which are currently unimplemented.

Issue 3 may be because of "pixel snapping". The bitmaps are set to non-smoothed, but Flash may clamp the bitmaps to pixel coordinates when rendering. I know this can apply to Bitmap objects/cacheAsBitmap MCs; I'm not sure if this applies to bitmap shapes (this case).

We do have to be careful because the normal Flash Player is not High DPI aware, so on my machine, Windows naturally filters the Flash Player window when it scales it up, causing smoothing, while Ruffle renders at the higher DPI, allowing the pixels to come through. So this may actually be correct rendering. Having an option to force bitmap smoothing is a TODO.

@Toad06
Copy link
Member Author

Toad06 commented May 15, 2020

Thanks for explaining! 😉

For the white line, this is the rendering I get:
wline
wlinezoom

@Toad06
Copy link
Member Author

Toad06 commented Jun 26, 2020

I've tried the Windows version on a third PC, and got another result again. This time, the program freezes (not responding), which did no longer happen in the most recent versions.

Intel UHD Graphics 620
Driver version: 26.20.100.7325

Now working in nightly 2020-08-28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rendering Area: Rendering & Graphics
Projects
None yet
Development

No branches or pull requests

3 participants