-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension: Log used renderer. #10909
extension: Log used renderer. #10909
Conversation
07786a2
to
b339da4
Compare
In fact this can be implemented completely on Rust side, and with greater simplicity, using just |
I think we wanted to make the message appear regardless of the logLevel, like the "new Ruffle instance created" message. (My idea was to add the renderer name to that message specifically.) |
Yes, the concept was to make it a bit more convenient to view which renderer-backend was used, such that you would not have to switch the logging level to "Info" first. I spent some time seeing if I could do it just from Rust, but I did not figure out how to do printing to the browser console apart from using The printing is in many ways inspired by the image in #10900 (comment) , which is taken from a Phaser 3 application. Additionally, another reason is that it would allow using an HTML-popup like with |
b339da4
to
7e11e45
Compare
7e11e45
to
a835d39
Compare
34e6efb
to
1e1b750
Compare
Log which renderer-backend was actually used in the browser console.
1e1b750
to
e54ffb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Log which renderer-backend was actually used in the browser console.
This is basically the same as #10903 , but without the toggle option for whether to warn or not if the actually used renderer is not the same as the preferred renderer.
Related to: #10835 , #10831 , #10900 .
CC: @n0samu @relrelb .