Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Add [API("674")] to Rectangle.copyFrom #17485

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Aaron1011
Copy link
Member

@Aaron1011 Aaron1011 commented Aug 12, 2024

This fixes old classes that extend Rectangle and define copyFrom without marking it as an override
Fixes #17423

@Dinnerbone
Copy link
Contributor

If you feel like fixing some more :D https://gist.github.com/Dinnerbone/0cfad60f4587292005d41e566368c709

@adrian17
Copy link
Collaborator

adrian17 commented Aug 12, 2024

Maybe we could limit the proposed scope to just flash.geom stuff? As these are super similar already.

@Dinnerbone
Copy link
Contributor

Yeah sorry I'm not asking to do all that right now, just thought I'd share the list :D

This fixes old classes that extend Rectangle and define `copyFrom`
without marking it as an override
@Aaron1011 Aaron1011 enabled auto-merge (rebase) August 12, 2024 23:26
@Aaron1011 Aaron1011 merged commit 79817f4 into ruffle-rs:master Aug 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants