avm2: Do not allocate for Namespace::any()
#17771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Namespace` now holds a `Option<Gc<_>>` internally, with `None` representing the Any namespace.
moulins
force-pushed
the
any-namespace-is-none
branch
from
7c074fd
to
74fc52b
Compare
torokati44
changed the title
Namespace::any()Namespace::any()
Lord-McSweeney
approved these changes
Sep 5, 2024
adrian17
approved these changes
Sep 5, 2024
|
Let's not allow this to start bit-rotting. |
torokati44
reviewed
Sep 6, 2024
Comment on lines
+373
to
+376
| && class_trait | ||
| .name() | ||
| .namespace() | ||
| .exact_version_match(avm2.as3_namespace) |
There was a problem hiding this comment.
Oh, wasn't this condition negated...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespacenow holds aOption<Gc<_>>internally, withNonerepresenting the Any namespace.This is closer to how avmplus represents namespaces internally (they use a
NULLpointer for the Any case), and allows creating the Any namespace without a&Mutation<'gc>.