avm2: Skip attempting to serialize methods #17787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
force-pushed
the
avm2-dont-serialize-methods
branch
from
2f13f0a
to
50fb3c3
Compare
evilpie
added
waiting-on-author
adrian17
force-pushed
the
avm2-dont-serialize-methods
branch
from
50fb3c3
to
ae99ad2
Compare
adrian17
added
waiting-on-review
adrian17
force-pushed
the
avm2-dont-serialize-methods
branch
from
ae99ad2
to
1b87297
Compare
evilpie
approved these changes
Sep 7, 2024
torokati44
approved these changes
Sep 7, 2024
Lord-McSweeney
removed
the
waiting-on-review
This was referenced Sep 11, 2024
Dinnerbone
added
T-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix most/99% of the regressions caused by added versioning, and 100% of the
property copyFrom not foundand similar ones.EDIT: do not merge until test is updated. Need to find a test that doesn't compare serialized length, as we and FP still appear to serialize in a different (even if compatible) way.