Revert "build: Freeze rustc for nightly builds to 1.80.1" #17812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #17785 and rust-lang/rust#129561 (comment) |
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Sep 10, 2024
…fle-rs#17812 Replace the use of Rust's standard sort in `Array.sort` and `sortOn` by a port of avmplus' QuickSort algorithm. This avoid panics on Rust >=1.81 when `Array.sort` is called with a non-Ord comparison function, and will always produce the same result as Flash Player.
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Sep 10, 2024
…fle-rs#17812 Replace the use of Rust's standard sort in `Array.sort` and `sortOn` by a port of avmplus' QuickSort algorithm. This avoid panics on Rust >=1.81 when `Array.sort` is called with a non-Ord comparison function, and will always produce the same result as Flash Player.
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Sep 10, 2024
…fle-rs#17812 Replace the use of Rust's standard sort in `Array.sort` and `sortOn` by a port of avmplus' QuickSort algorithm. This avoid panics on Rust >=1.81 when `Array.sort` is called with a non-Ord comparison function, and will always produce the same result as Flash Player.
moulins
added a commit
to moulins/ruffle
that referenced
this pull request
Sep 10, 2024
…fle-rs#17812 Replace the use of Rust's standard sort in `Array.sort` and `sortOn` by a port of avmplus' QuickSort algorithm. This avoid panics on Rust >=1.81 when `Array.sort` is called with a non-Ord comparison function, and will always produce the same result as Flash Player.
torokati44
pushed a commit
to moulins/ruffle
that referenced
this pull request
Sep 11, 2024
…fle-rs#17812 Replace the use of Rust's standard sort in `Array.sort` and `sortOn` by a port of avmplus' QuickSort algorithm. This avoid panics on Rust >=1.81 when `Array.sort` is called with a non-Ord comparison function, and will always produce the same result as Flash Player.
torokati44
pushed a commit
to moulins/ruffle
that referenced
this pull request
Sep 11, 2024
…fle-rs#17812 Replace the use of Rust's standard sort in `Array.sort` and `sortOn` by a port of avmplus' QuickSort algorithm. This avoid panics on Rust >=1.81 when `Array.sort` is called with a non-Ord comparison function, and will always produce the same result as Flash Player.
danielhjacobs
force-pushed
the
revert-17810-freeze-rust-version
branch
from
d1503e8
to
c6732ba
Compare
|
Rebased. This is probably good to merge, but it should be tested to make sure #17785 works properly still. |
torokati44
force-pushed
the
revert-17810-freeze-rust-version
branch
from
c6732ba
to
6e06adb
Compare
|
I actually can't reproduce that even before #17846... :/ On desktop at least. |
|
Just to be sure, though I assume so, you're testing with building with rust 1.81, right? |
|
Of course. The AVM trace is really helpful in suggesting that this is supposed to happen near the "end game screen", but for me, it didn't. |
torokati44
force-pushed
the
revert-17810-freeze-rust-version
branch
from
6e06adb
to
020ddca
Compare
adrian17
approved these changes
Sep 12, 2024
This reverts commit ff9ce69.
torokati44
force-pushed
the
revert-17810-freeze-rust-version
branch
from
020ddca
to
c3ceeb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #17810
Merge once the Vector.sort situation is sorted out.