Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/avm2: Remove some unnecessary warning logs #17817

Merged
merged 2 commits into from
Sep 11, 2024
Merged

core/avm2: Remove some unnecessary warning logs #17817

merged 2 commits into from
Sep 11, 2024

Conversation

Lord-McSweeney
Copy link
Collaborator

No description provided.

@moulins
Copy link
Contributor

moulins commented Sep 8, 2024

Why not keep the logs as tracing::info!? You never know when these could be useful.

@evilpie
Copy link
Collaborator

evilpie commented Sep 8, 2024

Why not change it to tracing::debug or tracing::trace instead?

@evilpie
Copy link
Collaborator

evilpie commented Sep 8, 2024

Haha collision. tracing::info is still our default log level, so we probably shouldn't use that.

@Lord-McSweeney
Copy link
Collaborator Author

Lord-McSweeney commented Sep 11, 2024 •
edited
Loading

This was worked out over Discord.

@Lord-McSweeney Lord-McSweeney enabled auto-merge (rebase) September 11, 2024 05:36
@Lord-McSweeney Lord-McSweeney merged commit 0adbf65 into ruffle-rs:master Sep 11, 2024
16 of 17 checks passed
@Lord-McSweeney Lord-McSweeney deleted the remove-nonmc-warn branch September 11, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lord-McSweeney @moulins @evilpie