avm2: Put more Multinames behind a Gc #17842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lord-McSweeney
force-pushed
the
avm2-multinames-stored
branch
from
176ab57
to
2be7a56
Compare
adrian17
approved these changes
Sep 11, 2024
Lord-McSweeney
force-pushed
the
avm2-multinames-stored
branch
from
2be7a56
to
d3dd750
Compare
Lord-McSweeney
force-pushed
the
avm2-multinames-stored
branch
from
d3dd750
to
e65b52c
Compare
added 2 commits
September 11, 2024 18:18
This should reduce Gc allocations when loading multiname index 0 from the cpool
…ltiname::to_qualified_name_or_star`
torokati44
force-pushed
the
avm2-multinames-stored
branch
from
e65b52c
to
5ed012a
Compare
|
Melted a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return types, slot types, and parameter types are all behind Gcs now. To avoid recreating the same Multiname several times while adding traits to classes, a
CommonMultinamesstructure storing some common multinames has been added toAvm2.