Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml: Cache regex in custom_unescape #17847

Merged
merged 1 commit into from
Sep 10, 2024
Merged

xml: Cache regex in custom_unescape #17847

merged 1 commit into from
Sep 10, 2024

Conversation

adrian17
Copy link
Collaborator

For a regex

new XML('<data><a x="0" y="0" w="0" h="0">data</a> (repeated 25 times) </data>');

This speeds up my microbenchmark by 4-5x.

@torokati44 torokati44 enabled auto-merge (rebase) September 10, 2024 16:01
@torokati44 torokati44 merged commit aded790 into ruffle-rs:master Sep 10, 2024
16 of 17 checks passed
@adrian17 adrian17 deleted the xml-faster-unescape branch September 10, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lord-McSweeney Lord-McSweeney Lord-McSweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian17 @Lord-McSweeney @torokati44