tests: Test exposed RufflePlayer API #17873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
force-pushed
the
test-exposed
branch
from
206030c
to
5653fa5
Compare
evilpie
force-pushed
the
test-exposed
branch
from
5653fa5
to
3922efa
Compare
|
displayMessage was made public once more so that should be tested here too. We should avoid adding anything else if possible until |
evilpie
force-pushed
the
test-exposed
branch
from
3922efa
to
7d72fb1
Compare
evilpie
added
A-tests
danielhjacobs
added
the
T-chore
evilpie
force-pushed
the
test-exposed
branch
from
7d72fb1
to
9df13ad
Compare
evilpie
force-pushed
the
test-exposed
branch
from
9df13ad
to
a9ed1e3
Compare
evilpie
force-pushed
the
test-exposed
branch
from
a9ed1e3
to
48ce7ab
Compare
evilpie
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures we notice when accidentally adding or removing something from the public RufflePlayer API.