Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Update Freedesktop categories #17909

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

kjarosh
Copy link
Member

@kjarosh kjarosh commented Sep 14, 2024

  1. Change order of categories. — Apparently the order matters when desktop environments decide to include the app only in one category. It seems that we should list more important categories first.
  2. Add VectorGraphics Freedesktop category — Ruffle handles SWF files, which are generally vector graphic animations.

@kjarosh kjarosh added A-desktop Area: Desktop Application linux waiting-on-review Waiting on review from a Ruffle team member labels Sep 14, 2024
@evilpie
Copy link
Collaborator

evilpie commented Sep 14, 2024

Is Audio/Video really the best category? Flash is still primarily interactive and not just playback.

@kjarosh
Copy link
Member Author

kjarosh commented Sep 14, 2024

I considered the following main categories [1]:

  1. AudioVideo
  2. Graphics
  3. Utility
  4. Game

Ad 4. it's hard to argue that the main use of Ruffle is gaming, Ruffle supports far wider content than games.

Ad 3. it seems that Utility is a category that includes random utilities (basic text editors, tools related to files, archiving & compression) [2]. I don't think this category describes what Ruffle does well, it can be argued whether Ruffle even fits in this category.

Ad 2. Graphics generally assumes non-interactive, static multimedia. Main content in Ruffle is interactive and dynamic.

Ad 1. AudioVideo is for "[...] presenting, creating, or processing multimedia". Granted, it does not mention that the multimedia may be interactive, but it also does not say or imply it's not.

I agree that there's no category that describes what Ruffle does in 100%, but I don't see a better main main (?) category than AudioVideo.

[1] https://specifications.freedesktop.org/menu-spec/latest/category-registry.html#main-category-registry
[2] https://specifications.freedesktop.org/menu-spec/latest/additional-category-registry.html

@evilpie
Copy link
Collaborator

evilpie commented Sep 15, 2024

You are definitely correct that there doesn't seem to be any category that is a perfect fit. Just terminology wise, and not directly based on the description, the two interesting ones are: Viewer is a sub-category of Graphics/Office and Player of Audio/Video. So, I guess I can agree with your ordering. Looking at the other examples (Clock and Calculator) and the description, we might actually want to remove the Utility category completely.

@kjarosh
Copy link
Member Author

kjarosh commented Sep 15, 2024

I'll do a separate PR for the removal of Utility so we can have a discussion there.

Apparently the order matters when desktop environments
decide to include the app only in one category.
It seems that we should list more important categories first.
Ruffle handles SWF files, which are generally vector graphic animations.
@kjarosh kjarosh enabled auto-merge (rebase) September 15, 2024 16:04
@kjarosh kjarosh removed the waiting-on-review Waiting on review from a Ruffle team member label Sep 15, 2024
@kjarosh kjarosh merged commit c378835 into ruffle-rs:master Sep 15, 2024
17 checks passed
@Dinnerbone Dinnerbone added A-desktop T-chore Type: Chore (like updating a dependency, it's gotta be done) labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application linux T-chore Type: Chore (like updating a dependency, it's gotta be done)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants