desktop: Migrate to winit 0.30's ApplicationHandler #18193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhjacobs
added
A-desktop
|
Tested on Wayland & X11, and everything seems to work properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the TODOs from #17401
Needs testing please! Largest change is to ControlFlow (specifically, how often we redraw things). In the previous update model, we'd force it to wait until the next frame time after every event we receive. Now, we conditionally do it at the end of a batch of events.
There's still another pending TODO (make the window later, instead of before event loop) - but that's a larger and messier change.
We can also clean up the ControlFlow usage further by using a callback in egui, but I didn't want to risk more changes than needed.