Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Create the window after the event loop #18225

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

Dinnerbone
Copy link
Contributor

This resolves the remaining TODO from #17401

Winit wants us to create the window after the event loop starts, and that wasn't very easy - but here we are.

Kindly requesting that someone tests on Wayland & X11 to make sure it's fine still :D

@Dinnerbone Dinnerbone added A-desktop Area: Desktop Application T-refactor Type: Refactor / Cleanup labels Oct 9, 2024
@torokati44
Copy link
Member

torokati44 commented Oct 9, 2024

(eager to see whether this finally resolves #8870 👀)
EDIT: No, it doesn't 🫠 It might be up to KDE/kwin_wayland...? 🤔
EDIT 2: Yeah, it works okay in Weston.

@torokati44
Copy link
Member

Couldn't spot any regressions in a quick test on X11 (XWayland) or Wayland (KDE and Weston). 🎉

@Dinnerbone Dinnerbone merged commit 0eccd9b into ruffle-rs:master Oct 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application T-refactor Type: Refactor / Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants