ci: Freeze rustc for nightly web builds to 1.81.0 #18397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian17
approved these changes
Oct 27, 2024
|
Should fix #18386 |
torokati44
added
A-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Tested locally (in Pale Moon), but not via CI.
Rust 1.82.0 enables the
reference-typesandmultivaluetarget features for the WebAssembly target by default: https://releases.rs/docs/1.82.0/#compatibility-notes. wasm-bindgen 0.2.94+ enables reference type and multivalue transformations if the module already makes use of the corresponding target features. Thereference-typesWebAssembly extension is not available in Safari 14.1, which we claim to support: https://caniuse.com/wasm-reference-types. It also, from testing, appears to not work in Pale Moon. Additionally, there seems to be some issues with support in Safari 15, which should support the reference-types extension but may have some bugs (which I don't expect will ever be fixed since Safari 15 isn't really supported anymore).Hopefully, this can be reverted after a wasm-bindgen release with rustwasm/wasm-bindgen#4213 is merged.