render: Flush draws before updating bitmap texture #19066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where new draws were drawn over an old GPU buffer.
For instance, consider the following scenario:
1. draw (GPU)
2. full fill (CPU)
3. draw (GPU)
When full fill is executed, the GPU buffer is discarded without a sync,
but we have to make sure we wait for any queued draws in order to
truly discard 1.
Co-authored-by: Nathan Adams <dinnerbone@dinnerbone.com>
kjarosh
added
A-rendering
Dinnerbone
approved these changes
Dec 25, 2024
|
Is this perhaps related to the regressions caused by #15032? |
This was referenced Dec 26, 2024
Yes, it is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where new draws were drawn over an old GPU buffer. For instance, consider the following scenario:
When full fill is executed, the GPU buffer is discarded without a sync, but we have to make sure we wait for any queued draws in order to truly discard 1.
Thank you @Dinnerbone for providing the fix!