Move the empty and one-char strings to CommonStrings, and allow istr! to access them.
#19465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moulins
changed the title
AvmString, and allow istr! to access them.CommonStrings, and allow istr! to access them.
moulins
force-pushed
the
istr-macro-extra-2
branch
2 times, most recently
from
4e3047c to
c9cfb54
Compare
Lord-McSweeney
added
A-core
Lord-McSweeney
approved these changes
Feb 9, 2025
...and make them available in the `istr!` and `atom!` macros.
moulins
force-pushed
the
istr-macro-extra-2
branch
from
c9cfb54 to
c7c486a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure this is worth the extra complexity in macro code, but this does have a few nice consequences:
"x"or"y", that were both in the one-char cache and inCommonStrings;istr!in more places makes code more readable, even if not that much shorter.