Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
build_shaders
feature in Ruffle'swgpu
backend andenable it on desktop. When enabled, the WGSL shaders are precompiled
using
naga
in a build script to the SPIR-V format. Then, thoseSPIR-V modules are used directly instead of the WGSL sources.
This approach has 2 major advantages:
(I expect 100KB-200KB), because the binary SPIR-V modules are much smaller
than the WGSL textual source code, plus hopefully the Rust compiler
will be smart enough to eliminate
naga
's WGSL parsing code, whichis pretty high on the
cargo bloat
list.loading precompiled SPIR-V modules.
However, I'm almost sure this feature won't work for WebGPU as it only supports WGSL. But maybe we can still minify the WGSL source code to reduce the WebAssembly binary size.