wgpu: Detect if buffers are unusable on web and fail to create wgpu renderer if so #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
force-pushed
the
intel_workaround
branch
from
8bff7ec to
1265b8b
Compare
Aaron1011
reviewed
Jan 12, 2023
render/wgpu/src/backend.rs
Outdated
| force_fallback_adapter: false, | ||
| }) | ||
| .await | ||
| .ok_or_else(|| "Unsupported device".to_string())?; |
There was a problem hiding this comment.
This makes us lose the nicer error message from build_descriptors. I think it would be better to better to call detect_buffer_bug from build_descriptors (possibly behind a flag).
There was a problem hiding this comment.
I'll split up build_descriptors into the adapter finding stuff only, we need that anyway for the upcoming libretro stuff
There was a problem hiding this comment.
Actually no nvm that means multiple block_ons at the caller, that can be a later change. I'll add a param!
There was a problem hiding this comment.
Ended up with cfg'ing it since it's only for web
Dinnerbone
force-pushed
the
intel_workaround
branch
from
1265b8b to
0f223ac
Compare
Aaron1011
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until gfx-rs/wgpu#3371 is fixed, this will allow us to use wgpu "most of the time".