Fix setting shard timeout #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was accepting the value but doing nothing. Closes ruflin#547
|
It turns out we've been running with this patch for a long time and never noticed it. We caught it when we upgraded. |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-Elastica
that referenced
this pull request
Feb 7, 2014
This contains a small patch, the contents of ruflin/Elastica#548 which fixes a bug found during the upgrade. Change-Id: I134ec3b67dd45b5ad4bbede305112b24c00c12eb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was accepting the value but doing nothing.
Closes #547