Improve performance of Status->getIndicesWithAlias #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $indices[] = $status->getIndex(); | ||
| $response = null; | ||
| try { | ||
| $response = $this->_client->request("/_alias/$alias"); |
There was a problem hiding this comment.
Can you use '/alias/' . $alias here instead? I'm not a too big fan of variables inside the strings ;-)
Particularly improves performance on clusters with many indices. Slow to instant. Closes ruflin#563
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-Elastica
that referenced
this pull request
Mar 4, 2014
Especially faster for cluster with logs of indices. Like, many orders of magnitude faster. Upstreamed with ruflin/Elastica#564 Change-Id: Id6619ae3d2545b4a687c10af9cea8b03be89ac8c
ruflin
added a commit
that referenced
this pull request
Mar 4, 2014
Improve performance of Status->getIndicesWithAlias
|
Merged. Thx |
|
Thank you. This will really help when I have to do an index rebuild to update mapping.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly improves performance on clusters with many indices. Slow
to instant.
Closes #563