Elasticsearch 1.4.2 #738

jdeniau · 2014-12-23T14:11:46Z

I tried to update to 1.4.2 (based on your 1.4.0 branch).

I now have 8 failing tests:
7 with this message :

Failed asserting that exception of type "Elastica\Exception\ResponseException" matches expected exception "\Elastica\Exception\RuntimeException". Message was: "ClusterBlockException[blocked by: [FORBIDDEN/5/index read-only (api)];]"

The last one is that Thread.sleep(100); is not authorized anymore now by ES

I do not know how to solve those problems :/

coveralls · 2014-12-23T14:28:40Z

Coverage decreased (-4.87%) when pulling 8d43da9 on jdeniau:elasticsearch-1.4.2 into c8b6848 on ruflin:master.

ruflin · 2014-12-23T16:14:38Z

I see about 85 tests failing: https://travis-ci.org/ruflin/Elastica/jobs/44939058

One of the problem seems to be the _createIndex function which is used by lots of tests: https://github.com/ruflin/Elastica/blob/master/test/lib/Elastica/Test/Base.php#L23

I assume some parameters with the shards or replicas have changed.

ruflin · 2015-01-02T17:27:17Z

@jdeniau Did you have any luck yet in fixing the issues?

jdeniau · 2015-01-02T23:06:33Z

No sorry I did not look at it this week.
Le 2 janv. 2015 18:27, "Nicolas Ruflin" notifications@github.com a écrit :

@jdeniau https://github.com/jdeniau Did you have any luck yet in fixing
the issues?

—
Reply to this email directly or view it on GitHub
#738 (comment).

jdeniau · 2015-01-19T16:48:51Z

I worked on it today.
The main problem is that the "read_only" instruction seem to block all queries, (see elastic/elasticsearch#9203 ).

I am down to ~15 errors for now, I will commit changes soon.

coveralls · 2015-01-19T17:45:32Z

Coverage decreased (-0.01%) when pulling 435c724 on jdeniau:elasticsearch-1.4.2 into bca7a12 on ruflin:master.

ruflin · 2015-01-19T21:49:04Z

@jdeniau That looks really promising. Only 1 error left. Make sure to merge in master as there are also quite a few changes.

I also started to work on it but you are already much farther: https://github.com/ruflin/Elastica/tree/elasticsearch-1.4.0

ruflin · 2015-01-19T21:51:51Z

lib/Elastica/Index/Settings.php

+     */
+    public function getReadOnly()
+    {
+        return $this->get('blocks.write') === 'true'; // ES returns a string for this setting


This variable sounds so counterintuitive. But it is 100% correct. I also checked the ES docs.

jdeniau · 2015-01-20T07:46:45Z

The failing test is really weird.

Actually, it goes well on my local instance of ES.
Moreover the code on master is :

// the document with the random score should have a score > 1, means it is the first result       
$result0 = $results[1]->getData();

But the first document is $results[0], not $results[1] (as said in the variable $result0 too)

coveralls · 2015-01-20T08:06:36Z

Coverage decreased (-0.01%) when pulling 6a72343 on jdeniau:elasticsearch-1.4.2 into bca7a12 on ruflin:master.

coveralls · 2015-01-20T09:02:31Z

Coverage decreased (-0.01%) when pulling 056107e on jdeniau:elasticsearch-1.4.2 into bca7a12 on ruflin:master.

ruflin · 2015-01-20T09:07:11Z

lib/Elastica/Index/Settings.php

@@ -68,31 +68,33 @@ public function get($setting = '')
        $requestData = $this->request()->getData();
        $data = reset($requestData);

+        if (empty($data['settings']) || empty($data['settings']['index'])) {
+            return []; // index not found


Should we actually throw a not found exception here?

coveralls · 2015-01-20T09:31:38Z

Coverage decreased (-0.01%) when pulling 867ef2a on jdeniau:elasticsearch-1.4.2 into bca7a12 on ruflin:master.

coveralls · 2015-01-20T09:43:20Z

Coverage decreased (-0.01%) when pulling 867ef2a on jdeniau:elasticsearch-1.4.2 into bca7a12 on ruflin:master.

jdeniau · 2015-01-20T09:47:10Z

Sorry to push a lot but I have some differences between travis and my localhost instance :(

I took the responsability of removing the 5.3 support. I only did that to allow array short syntax, so it is easily revertable, but as the 5.3 version is not officially supported by the PHP developers, I think it is a good think to remove it.

But it's up to you, if you want to revert, I'll do it.

ruflin · 2015-01-20T09:50:06Z

@jdeniau No problem. The main priority is getting 1.4.2 running. To make it then compatible again with 5.3 if necessary is an other thing. Lets not focus on this right now.

ruflin · 2015-01-20T10:07:09Z

@jdeniau All green. Let me know when I can merge.

jdeniau · 2015-01-20T10:32:12Z

OK for me when the next build is OK.

jdeniau · 2015-01-20T11:00:37Z

It's OK for me ! :)

im-denisenko · 2015-01-20T11:06:00Z

.travis.yml

 env:
+  global:


This block(9-16) was deleted by me in #742.
Packages versions should be specified in ansible/es-playbook.yml now.
Actually, travis built your pull request with ES 1.3.4, as i can see from logs :)

Thanks for checking ...

ruflin · 2015-01-20T11:07:13Z

@jdeniau Can you please have a look at this?

…h#9203 is open

There is an issue with that: ruflin#712 But as the Client object has a public setLogger method with a strong dependency on LoggerInterface, the psr/log is automatically a strong dependancy of the package.

jdeniau · 2015-01-21T10:24:29Z

Finally 😎
I am not proud of this commit jdeniau@07b56f6 but it is the same kind of problem we have with the readonly.

Once merged, you can merge #735 (I updated it)

im-denisenko · 2015-01-21T15:07:36Z

composer.json

@@ -12,10 +12,10 @@
        }
    ],
    "require": {
-        "php": ">=5.3.3"
+        "php": ">=5.3.3",


With arrays new syntax, ">=5.4.0"

I tried that but got a weird bug with composer in the tests installation process:
https://travis-ci.org/ruflin/Elastica/builds/47757241

I've found a problem.

ubuntu 12.04 default php version is 5.3

ansible uses sudo internally for all steps

when you use phpenv as travis does, php and sudo php is different versions of php

sudo composer can't satisfy ">=5.4" requirement, becase uses system php, which 5.3

ansible wipe out all stderr from composer so it fails silently =/

Moreover, vagrant box is broken again, as there only one php version - 5.3

I'll fix this issue.

Thx. Looking forward to it.

Elasticsearch 1.4.2

ruflin · 2015-01-21T16:39:03Z

@jdeniau I merged it in :-) That was a big pice of work. Thanks a lot.

Will you keep an eye on elastic/elasticsearch#9203 ? I assume as soon as it is merged in and release, it will break again the implementation.

ruflin · 2015-01-21T16:50:58Z

@jdeniau BTW: I think we forgot to update the README: https://github.com/ruflin/Elastica/blob/master/README.markdown

jdeniau · 2015-01-22T07:24:28Z

I created another PR #756 for this.

Thanks for the merge !

For the metadata bug on ES itself, it will be part of a new ElasticSearch version. I'll watch about it.

jdeniau mentioned this pull request Dec 23, 2014

Implement the weight in the function score query #735

Merged

ruflin and others added 5 commits January 19, 2015 18:09

Update to elasticsearch 1.4.0

1435c89

Update changes.txt file. Remove tearDown function from ScriptFieldTest

72fa3c5

update to elasticsearch 1.4.2

ea235bc

memory increased ?

4e2e6e2

fix read-only bug

435c724

jdeniau force-pushed the elasticsearch-1.4.2 branch from 82e5408 to 435c724 Compare January 19, 2015 17:12

ruflin reviewed Jan 19, 2015
View reviewed changes

jdeniau force-pushed the elasticsearch-1.4.2 branch 2 times, most recently from 4201e39 to 80632d3 Compare January 20, 2015 07:59

jdeniau force-pushed the elasticsearch-1.4.2 branch 3 times, most recently from c186d85 to 867ef2a Compare January 20, 2015 09:02

ruflin reviewed Jan 20, 2015
View reviewed changes

jdeniau added 2 commits January 20, 2015 10:43

reset master functionnality

da0d7c3

throw index not found exception

bce448a

jdeniau force-pushed the elasticsearch-1.4.2 branch from 867ef2a to bce448a Compare January 20, 2015 09:44

add test for notfoundindex

75e140b

im-denisenko reviewed Jan 20, 2015
View reviewed changes

jdeniau added 8 commits January 20, 2015 15:03

wrong version of ES

ea50b32

update elasticsearch-mapper-attachement to 2.4.1

aee5fa8

Mapping must be set for percolator

835df40

result0 is the first result

0b69a6a

mock thead call as ES disabled it in ES 1.4

ce98bf6

fix function definition

4b5e827

Hacky way to avoid block on metadata check while elastic/elasticsearc…

07b56f6

…h#9203 is open

psr/log is a dependency

59e51c0

There is an issue with that: ruflin#712 But as the Client object has a public setLogger method with a strong dependency on LoggerInterface, the psr/log is automatically a strong dependancy of the package.

jdeniau force-pushed the elasticsearch-1.4.2 branch from d71f829 to 59e51c0 Compare January 21, 2015 10:05

im-denisenko reviewed Jan 21, 2015
View reviewed changes

ruflin added a commit that referenced this pull request Jan 21, 2015

Merge pull request #738 from jdeniau/elasticsearch-1.4.2

9d284d5

Elasticsearch 1.4.2

ruflin merged commit 9d284d5 into ruflin:master Jan 21, 2015

jdeniau deleted the elasticsearch-1.4.2 branch January 22, 2015 07:21

im-denisenko mentioned this pull request Jan 24, 2015

Fix cluster setup/Update php version #759

Merged

im-denisenko mentioned this pull request Jan 31, 2015

Housekeeping part two #764

Merged

Tobion mentioned this pull request Feb 16, 2017

Fix reading bool index setting & deprecate ElasticsearchException #1251

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Elasticsearch 1.4.2 #738

Elasticsearch 1.4.2 #738

jdeniau commented Dec 23, 2014

coveralls commented Dec 23, 2014

ruflin commented Dec 23, 2014

ruflin commented Jan 2, 2015

jdeniau commented Jan 2, 2015

jdeniau commented Jan 19, 2015

coveralls commented Jan 19, 2015

ruflin commented Jan 19, 2015

ruflin Jan 19, 2015

jdeniau commented Jan 20, 2015

coveralls commented Jan 20, 2015

coveralls commented Jan 20, 2015

ruflin Jan 20, 2015

coveralls commented Jan 20, 2015

coveralls commented Jan 20, 2015

jdeniau commented Jan 20, 2015

ruflin commented Jan 20, 2015

ruflin commented Jan 20, 2015

jdeniau commented Jan 20, 2015

jdeniau commented Jan 20, 2015

im-denisenko Jan 20, 2015

ruflin Jan 20, 2015

ruflin commented Jan 20, 2015

jdeniau commented Jan 21, 2015

im-denisenko Jan 21, 2015

jdeniau Jan 21, 2015

im-denisenko Jan 21, 2015

ruflin Jan 23, 2015

ruflin commented Jan 21, 2015

ruflin commented Jan 21, 2015

jdeniau commented Jan 22, 2015

Elasticsearch 1.4.2 #738

Elasticsearch 1.4.2 #738

Conversation

jdeniau commented Dec 23, 2014

coveralls commented Dec 23, 2014

ruflin commented Dec 23, 2014

ruflin commented Jan 2, 2015

jdeniau commented Jan 2, 2015

jdeniau commented Jan 19, 2015

coveralls commented Jan 19, 2015

ruflin commented Jan 19, 2015

Choose a reason for hiding this comment

jdeniau commented Jan 20, 2015

coveralls commented Jan 20, 2015

coveralls commented Jan 20, 2015

Choose a reason for hiding this comment

coveralls commented Jan 20, 2015

coveralls commented Jan 20, 2015

jdeniau commented Jan 20, 2015

ruflin commented Jan 20, 2015

ruflin commented Jan 20, 2015

jdeniau commented Jan 20, 2015

jdeniau commented Jan 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ruflin commented Jan 20, 2015

jdeniau commented Jan 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ruflin commented Jan 21, 2015

ruflin commented Jan 21, 2015

jdeniau commented Jan 22, 2015