Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search functionality (using AngularJS) #4

Closed
wants to merge 9 commits into from

Conversation

shirkey
Copy link

@shirkey shirkey commented Apr 2, 2013

Added in-page search of results per Issue #2, also filtering to only display entities in the /files subdirectory of the bucket -- it seemed the simplest way to firewall the app applicaton from the files themselves, perhaps this can be a configurable option (along with S3 bucket URL setting) later. I also took the liberty of removing jQuery since Angular has a subset of the core jQuery functionality, but feel free to add it back in.

Thanks,
Steve

@rufuspollock
Copy link
Owner

Hi Steve, I've held on merging this as I'm a bit hesitant to bring such a substantial framework given the relatively simple needs here. For search I'd been imaging simple regex style.

Aside: I like the idea of being able to filter on a given prefix but I feel a separate issue and pull request would be in order -- it would make it much easier to review and merge :-)

@shirkey
Copy link
Author

shirkey commented Apr 3, 2013

Hi Rufus -- yes, I can certainly see then where the scope diverges from your original -- my intention is something client-facing, like a private-labeled dropbox/ge.tt/mega.co.nz that could be dropped in a bucket and served up from a custom URL (eg files.acme.com/clientA). I really would like something that can avoid the traps of IT Security at various clients blocking any of those sites, this seems like a possibility if I can add security to this.

Re: the filter -- do you have a preference for filtering the index.html and associated Javascript files from the S3 bucket itself a la the separate folder idea or did you have something else in mind?

I'm not familiar with particular protocol (ie. the Tao of Github), but feel free to close this pull request then. Cheers!

@shirkey shirkey closed this Apr 23, 2013
@rufuspollock
Copy link
Owner

@shirkey sorry to slow response here. The pull request was really appreciated but I think my planned suggestion was to boot a separate repo for the really fully featured app. I presume this is what you may be doing - if so do put a link so people can check it out (perhaps i can even contribute!)

I certainly think search is still needed but wonder if we can do it in a super lightweight way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants