[WIP] Upgrade to Emoji-Mart v5 #128
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rugk
commented
Jun 15, 2022
src/popup/module/EmojiPicker.js
Outdated
| @@ -5,6 +5,8 @@ | |||
| */ | |||
|
|
|||
| import * as EmojiSelect from "./EmojiSelect.js"; | |||
| import data from "/node_modules/@emoji-mart/data"; | |||
There was a problem hiding this comment.
The problem in the official guide was that this is not an ECMAstandard apparently. This here should load a combined JSON, but dpoes not work in Firefox like this.
There was a problem hiding this comment.
That's why I now tried using the unpkg version, but it did not work in my testing before, too.
There was a problem hiding this comment.
Yeah, one cannot yet import JSON files as a module (see here). I believe the solution would be to remove this line and then use a hack like this below:
const emojiPicker = new EmojiMart.Picker({ ...initProperties, data: async () => {
const response = await fetch(browser.runtime.getURL("/node_modules/@emoji-mart/data/sets/14/native.json"));
return response.json();
}});
rugk
commented
Jun 15, 2022
| "homepage": "https://github.com/rugk/awesome-emoji-picker#readme", | ||
| "dependencies": { | ||
| "@emoji-mart/data": "^1.0.1", | ||
| "emoji-mart": "^5.0.0" |
There was a problem hiding this comment.
TODO: Update to emoji-mart v5.1.0
https://github.com/missive/emoji-mart/releases/tag/v5.1.0
rugk
commented
Jun 15, 2022
| } | ||
|
|
||
| console.log(data); |
There was a problem hiding this comment.
TODO: rmeove when finished ebugging :O
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention: This is a draft and does not work yet.
Fixes #116
FYI @tdulcet sorry and thanks for making me aware of the priority here (keep doing that), I already had a branch in progress, so I just created this draft PR. It does not wokr and I got stuck though, see below.