Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GitHubActions to build for android #237

Closed
wants to merge 1 commit into from
Closed

add GitHubActions to build for android #237

wants to merge 1 commit into from

Conversation

leleliu008
Copy link
Contributor

No description provided.

@rui314
Copy link
Owner

rui314 commented Jan 4, 2022

Could you read https://github.com/rui314/mold/blob/main/CONTRIBUTING.md and add a signed-off-by line to your commit message?

@leleliu008 leleliu008 force-pushed the add-github-actions-android-yml branch 3 times, most recently from 5d66b54 to 38f9d2b Compare January 4, 2022 20:35
@rui314
Copy link
Owner

rui314 commented Jan 7, 2022

This looks a bit too complicated -- it builds various targets on various hosts and downloads some tar file from other repo using curl. I think that just build mold by running make on a single host (Android on ARM64) would suffice. Do you mind if I ask you to strip this patch down to minimum? I'm not familiar with GitHub actions, but if you don't have time to do that, I'll do that later.

@leleliu008
Copy link
Contributor Author

leleliu008 commented Jan 7, 2022 •
edited
Loading

and downloads some tar file from other repo using curl.

this project need external prebuild openssl.

@leleliu008 leleliu008 force-pushed the add-github-actions-android-yml branch from 38f9d2b to f626e13 Compare January 7, 2022 17:33
@leleliu008
add GitHubActions to build for android
f06db5e 
Signed-off-by: leleliu008 <leleliu008@gmail.com>
@leleliu008 leleliu008 force-pushed the add-github-actions-android-yml branch from f626e13 to f06db5e Compare January 7, 2022 17:40
@rui314 rui314 force-pushed the main branch 2 times, most recently from 20d1729 to 2464a55 Compare January 10, 2022 15:20
@rui314 rui314 force-pushed the main branch 3 times, most recently from 28b2820 to 7a8c14a Compare January 16, 2022 04:32
@rui314 rui314 force-pushed the main branch 8 times, most recently from 3117f24 to f181b11 Compare April 29, 2022 11:27
@rui314 rui314 force-pushed the main branch 5 times, most recently from 4652763 to 230976a Compare May 1, 2022 08:04
@rui314 rui314 force-pushed the main branch 2 times, most recently from 192efa1 to a1711b9 Compare May 21, 2022 12:31
@rui314 rui314 force-pushed the main branch 3 times, most recently from ccf2cda to 7d91674 Compare August 3, 2022 03:29
@rui314 rui314 force-pushed the main branch 3 times, most recently from cc86039 to 25d02bb Compare January 14, 2023 02:22
@leleliu008 leleliu008 closed this by deleting the head repository Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leleliu008 @rui314