Make libexec symlink relocatable #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When packaging mold, one might want to "make install" the build artifacts into a directory that will be archived, then deployed somewhere else. This commit changes this result… $ make install DESTDIR=pkg PREFIX="" $ readlink pkg/libexec/mold/ld /bin/mold … into this… $ readlink pkg/libexec/mold/ld ../../bin/mold … which will remain correct wherever we end up installing the contents of "pkg". Signed-off-by: Kévin Le Gouguec <legouguec@adacore.com>
|
I wanted to do this, but it looks like |
rui314
added a commit
that referenced
this pull request
Apr 16, 2022
I didn't want to write a Python one-liner in the Makefile, but it looks like it is in practice one of the most portable way to compute a relative path. #425
|
I did this using Python in the above commit. |
|
Thanks! Sorry we couldn't find a more "lightweight" solution (IIUC pulling in GNU coreutils is doable on MacOS; not sure about the BSDs?). I've updated my branch with a further tweak: adding main...peniblec:relative-symlink Should I submit a new PR? |
rui314
added a commit
that referenced
this pull request
Apr 16, 2022
Pointed out by Kévin Le Gouguec in #425.
|
I removed |
|
Thanks again, should work just as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a slight tweak to the symlink in libexec to allow packagers to archive build artifacts, and untar the archive under different paths.
As shown in the commit message, the current link is absolute, so it will not be resolved properly (1) while mold sits in DESTDIR (2) if the build artifacts are deployed under a different PREFIX.
Thank you for your time, and let me know if you need more context about the use-case!