chore - simplify linking step #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #4 for the file path check. I don't think that we need to print out the value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
echo "${{ inputs.make-default }}"to respect the same standard as the step just before.true -a "$(realpath /usr/bin/ld)" != /usr/local/bin/moldwill always evaluate to false asmoldis not yet included by default in popular systems. As a result I believe we can let this line go.sudo ln -sf /usr/local/bin/mold "$(realpath /usr/bin/ld)"can be its own line as it should always evaluate to true and if it cannot force link for some reasons we want to be notified.