Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'getrpcinfo' missing method for version 0.18.0 #100

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Add 'getrpcinfo' missing method for version 0.18.0 #100

merged 1 commit into from
Sep 27, 2019

Conversation

sskender
Copy link
Contributor

No description provided.

@pedrobranco
Copy link
Collaborator

pedrobranco commented Sep 17, 2019

@sskender Can you include in this PR all the other 0.18 RPC methods and REST endpoints?

@pedrobranco
Copy link
Collaborator

pedrobranco commented Sep 17, 2019

And also add the deprecated / removed RPCs.

@sskender
Copy link
Contributor Author

Included new and deprecated 0.18 RPC methods

Copy link
Collaborator

@pedrobranco pedrobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit and please squash all the commits and rename to Add support for bitcoin@0.18.0 methods.

src/methods.js Outdated
@@ -179,7 +179,7 @@ export default {
features: {
multiwallet: '>=0.15.0'
},
version: '>=0.11.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the misinformation in here but revert this change because generate is only deprecated (not removed).

Copy link
Collaborator

@pedrobranco pedrobranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants