Fix bug when calling REST method with extension bin
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobranco
force-pushed
the
bugfix/fix-bug-in-rest-with-bin-extension
branch
from
4deab74
to
cb7161f
Compare
pedrobranco
force-pushed
the
bugfix/fix-bug-in-rest-with-bin-extension
branch
2 times, most recently
from
9ce9a14
to
c2fc2f6
Compare
ruimarinho
requested changes
Nov 17, 2017
test/index_test.js
Outdated
|
|
||
| hex.should.endWith('cf900000000\n'); | ||
| }); | ||
| it('should match a transaction binary-encoded with hex-encoded', async () => { |
There was a problem hiding this comment.
I would keep the same description as the test implementation is not really important in this case.
test/index_test.js
Outdated
| @@ -434,13 +434,26 @@ describe('Client', () => { | |||
| block.should.have.keys('bits', 'chainwork', 'confirmations', 'difficulty', 'hash', 'height', 'mediantime', 'merkleroot', 'nextblockhash', 'nonce', 'size', 'strippedsize', 'time', 'tx', 'version', 'versionHex', 'weight'); | |||
| block.tx.should.matchEach(value => value.should.be.a.String()); | |||
| }); | |||
|
|
|||
| it('should match a transaction binary-encoded with hex-encoded', async () => { | |||
There was a problem hiding this comment.
Or keep the original test description:
should return a block binary-encoded if extension is `bin`
c2fc2f6
to
492c82f
Compare
ruimarinho
force-pushed
the
bugfix/fix-bug-in-rest-with-bin-extension
branch
from
492c82f
to
b360dfc
Compare
ruimarinho
approved these changes
Nov 17, 2017
ruimarinho
force-pushed
the
bugfix/fix-bug-in-rest-with-bin-extension
branch
from
b360dfc
to
fdd41f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when calling REST methods with
extension: binwhich were retrieving invalid data on response buffer.