Improve response handling #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruimarinho
force-pushed
the
enhancement/improved-response-handling
branch
from
fcd537e
to
7341c87
Compare
joaopaulofonseca
requested changes
Nov 26, 2017
test/index_test.js
Outdated
|
|
||
| const [newAddressError, addressValidation] = await new Client(config.bitcoind).command(batch); | ||
|
|
||
| addressValidation.should.have.properties('address', 'isvalid', 'ismine', 'scriptPubKey'); |
src/parser.js
Outdated
| throw new RpcError(response.statusCode, response.statusMessage); | ||
| } | ||
|
|
||
| function getRpcBody(body, { headers = false, response } = {}) { |
There was a problem hiding this comment.
Please update the method description as well.
ruimarinho
force-pushed
the
enhancement/improved-response-handling
branch
from
7341c87
to
0f2ca1a
Compare
joaopaulofonseca
approved these changes
Nov 27, 2017
* Better error handling for both RPC and REST calls.
* Handle `text/html` and `text/plain` differences from both request
types correctly.
* Proxy response errors as error messages for easier debugging.
* Add a test for batched requests where one of the request fails.
* Handle errors in binary-encoded requests.
* Parse REST responses with JSONBigInt to avoid losing precision. This
means that some of the response values will now be strings (e.g.
the network difficulty on `getDifficulty()`).
ruimarinho
force-pushed
the
enhancement/improved-response-handling
branch
from
0f2ca1a
to
093d562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text/htmlandtext/plaindifferences from both request types correctly.getDifficulty()).