Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.3.2 #25

Merged
merged 13 commits into from
Aug 26, 2024
Merged

0.3.2 #25

merged 13 commits into from
Aug 26, 2024

Conversation

andrecastro0o
Copy link
Member

closes #2

Andre Castro added 9 commits August 20, 2024 13:09
moved (unitless) from standard_name to long_name in var definition
db63ee9
moved (unitless) from standard_name to long_name in var definition (#19)
3edefc6
Merge branch '0.3.2' of github.com:ruisdael-observatory/disdroDL into…
8f3e2cd 
… 0.3.2
16 make long name values consistent (#20)
f7a1813 
* moved (unitless) from standard_name to long_name in var definition

* long_name:...(unitless) -> long_name:...[unitless]

* units added to all vars long_names

* units added to all vars long_names in configs_netcdf/config_general_parsivel.yml

* last fixes to units in long_name
Merge branch '0.3.2' of github.com:ruisdael-observatory/disdroDL into…
38c8621 
… 0.3.2
unecessary variables instructed to never be included in NetCDFs (#21)
2cf0abc
official instruments documentation links added to readme (#22)
1014f3c
comments refering to Table 7 made consistent (#23)
00b665e
vars number_of_* dtype=i2 (16bit int) (#24)
4ffa4ea
@andrecastro0o andrecastro0o self-assigned this Aug 20, 2024
mschleiss
mschleiss approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@mschleiss mschleiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can judge, this makes sense. The 16bit unsigned integer type will save memory while also giving us a large enough range for logging the number of particles per minute. The rest of the changes align well with what I had in mind.

@andrecastro0o
Copy link
Member Author

disdroDL version 0.3.2 on deployed PAR008 and THIES006 (same GV device)

On Monday we shall check the resulting NetCDFs and based on the results merge this branch to main

@andrecastro0o andrecastro0o mentioned this pull request Aug 26, 2024
Closed
@andrecastro0o andrecastro0o merged commit eb52dc4 into main Aug 26, 2024
1 check passed
@andrecastro0o andrecastro0o deleted the 0.3.2 branch August 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschleiss mschleiss mschleiss approved these changes

Assignees

@andrecastro0o andrecastro0o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assess the quality of generated NetCDFs (thies and parsivel)
2 participants
@andrecastro0o @mschleiss