Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "--experimental_allow_proto3_optional" protoc option #105

Closed
sjoerdvisscher opened this issue Feb 8, 2021 · 2 comments · Fixed by #106
Closed

Add support for "--experimental_allow_proto3_optional" protoc option #105

sjoerdvisscher opened this issue Feb 8, 2021 · 2 comments · Fixed by #106
Labels
enhancement New feature or request resolved-next-release Code to resolve issue is pending release

Comments

@sjoerdvisscher
Copy link

I'd like to enable the --experimental_allow_proto3_optional protoc option. Maybe this is already possible, but I was not able to figure out how.

@aaliddell
Copy link
Member

This will be supported in 3.0.0 #106:

python_proto_compile(
    name = "person_python_proto",
    protos = ["@rules_proto_grpc//example/proto:person_proto"],
    extra_protoc_args = ["--experimental_allow_proto3_optional"]
)

@aaliddell aaliddell added enhancement New feature or request resolved-next-release Code to resolve issue is pending release labels Feb 14, 2021
@sjoerdvisscher
Copy link
Author

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resolved-next-release Code to resolve issue is pending release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants