Update C# rules #110
Update C# rules #110
Conversation
## What? Updates the C# rules to the latest version of rules_dotnet ## Why? The latest version of rules_dotnet has gone through significant refactoring after dropping .Net Framework and Mono support and these rules need to be updated to be compatable
|
Should be ready for review @aaliddell |
|
Awesome, thanks for the PR. I'm going to have to check how the overriding of platforms is going to work with the 'build and test all' CI task, which has some other issues presently that may be masking platform related troubles. Also, the changes made to the presubmit flags will get overwritten when rulegen is run. This should have been flagged by the diff CI check, which I don't have set to run on PRs to other branches 🤦♂️. |
|
@aaliddell I also added a commit that fixes an issue with remote execution. I can split it into another PR if you prefer. |
Is it this commit b48fadd? I don't mind it being in here. Once I've got gRPC gateway fixed to make CI green in dev branch I'll be looking to merge this. |
github-actions
bot
added
dependencies
|
Pending on bazel-contrib/rules_dotnet#225, since overriding the platforms is a significant requirement that may be avoidable. |
aaliddell
force-pushed
the
update-csharp-rules-take2
branch
from
ae8e562
to
0ce2d6c
Compare
What?
Updates the C# rules to the latest version of rules_dotnet
Why?
The latest version of rules_dotnet has gone through significant refactoring after dropping .Net Framework and Mono support and these rules need to be updated to be compatable