Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new set of metrics #24

Open
DavidLambauer opened this issue Nov 8, 2021 · 0 comments
Open

Create a new set of metrics #24

DavidLambauer opened this issue Nov 8, 2021 · 0 comments

Comments

@DavidLambauer
Copy link
Member

DavidLambauer commented Nov 8, 2021 •
edited
Loading

For now, we're having a bunch of different metrics but still have more that we want to provide.

To enhance the current functionality of the module, we'd like to add the following metrics:

  • magento_shipments_count_total
  • magento_catalog_category_count_total
  • magento_website_count_total
  • magento_store_count_total

The following labels shall always be included in each metric:

  • store_code

We need to prioritize performance in our data collectors as this module is used by Magento Stores that are quite large.

Make sure to test and document the changes.
@DavidLambauer DavidLambauer changed the title Create Order Shipment Metrics Create a new set of metrics Nov 8, 2021
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
4861c2c 
- add state fix for console command
- add command option resolving fix
- add shipments aggregator
- add shipments count aggregator unit tests coverage.
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
fc06fbe 
- add categories count aggregator based on category status, category menu status and store code
- add unit tests coverage for categories count aggregator.
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
44b753a 
- adjust 'magento_store_count_total' metric;
- add status label to stores count;
- adjust unit tests coverage;
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
fbcbf53 
- Add magento_website_count_total metric.
- add unit tests coverage.
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
9cc87e9 
- Update readme.md file.
@swnsma swnsma mentioned this issue Nov 13, 2021
Merged
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
fe5d572 
- Fix code styles.
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 13, 2021
@swnsma
run-as-root#24:
c360002 
- Fix code styles.
swnsma added a commit to swnsma/magento2-prometheus-exporter that referenced this issue Nov 18, 2021
@swnsma
run-as-root#24:
e6ae0ef 
Fix code review notices.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
785db5a 
- add state fix for console command
- add command option resolving fix
- add shipments aggregator
- add shipments count aggregator unit tests coverage.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
1a43744 
- add categories count aggregator based on category status, category menu status and store code
- add unit tests coverage for categories count aggregator.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
a7cb3d5 
- adjust 'magento_store_count_total' metric;
- add status label to stores count;
- adjust unit tests coverage;
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
e8690c1 
- Add magento_website_count_total metric.
- add unit tests coverage.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
19cd51e 
- Update readme.md file.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
f27172b 
- Fix code styles.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
3776ab5 
- Fix code styles.
randallelliott714 added a commit to randallelliott714/prometheus-exporter-magento2 that referenced this issue Oct 18, 2022
@randallelliott714
run-as-root/magento2-prometheus-exporter#24:
bedb2d0 
Fix code review notices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidLambauer