Skip to content

Commit

Permalink
Use kubernetes command runner in cluster
Browse files Browse the repository at this point in the history
  • Loading branch information
carolineechen committed Aug 29, 2024
1 parent 2084323 commit 8bdc90b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions runhouse/resources/hardware/sky_ssh_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,6 @@ def run(
skip_lines=skip_lines,
source_bashrc=source_bashrc,
)
# RH MODIFIED
if self.docker_user:
command_str = f"cd /{self.docker_user} && {command_str}"
command = kubectl_base_command + [
# It is important to use /bin/bash -c here to make sure we quote the
# command to be run properly. Otherwise, directly appending commands
Expand Down
2 changes: 0 additions & 2 deletions runhouse/resources/hardware/ssh_tunnel.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def __init__(
if ssh_control_name is None
else _generate_ssh_control_hash(ssh_control_name)
)
self.ssh_control_name = ssh_control_name
self.ssh_proxy_command = ssh_proxy_command
self.disable_control_master = disable_control_master

Expand All @@ -75,7 +74,6 @@ def __init__(
self.tunnel_proc = None

def tunnel(self, local_port, remote_port):
# TODO - modifications needed for k8s docker command to work
base_cmd = _ssh_base_command(
address=self.ip,
ssh_user=self.ssh_user,
Expand Down

0 comments on commit 8bdc90b

Please sign in to comment.