Check ips for ondemand clusters when loading from Den #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
carolineechen
force-pushed
the
cc/ssh-local
branch
from
ae7c983 to
91072f7
Compare
carolineechen
force-pushed
the
cc/cluster-load-ips
branch
from
f4dd557 to
37f529b
Compare
carolineechen
force-pushed
the
cc/ssh-local
branch
from
91072f7 to
b1b5fda
Compare
dongreenberg
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when loading on demand cluster from name (Den), if different IPs are found in the local sky db (refresh=False), then update the IPs. the local IPs should be more recent than the saved IPs
note: it is possible the cluster was autodowned but still in the local db, in this case the local IPs will still be used but won't work (calling up_if_not or _ping will correct this, but this is to avoid calling refresh in the constructor).
note: we do not resave the cluster either