Change resync_rh to None by default and match Ray version.
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohinb2
changed the title
resync_rh to False by default.resync_rh to None by default.
rohinb2
force-pushed
the
07-16-Change_resync_rh_to_False_by_default
branch
2 times, most recently
from
d3c4c86 to
3ff0ef9
Compare
rohinb2
changed the title
resync_rh to None by default.resync_rh to None by default and match Ray version.
| stream_logs=True, | ||
| ) | ||
|
|
||
| if installed_editable_locally or resync_rh: |
There was a problem hiding this comment.
if resync_rh is False, that means it's explicitly set and we shouldn't resync even if it is an editable
There was a problem hiding this comment.
I won't even enter this function if resync_rh is False
There was a problem hiding this comment.
if installed_editable is True but resync_rh is False it'll still enter this right?
| restart_ray: bool = True, | ||
| restart_proxy: bool = False, | ||
| logs_level: str = None, | ||
| ): | ||
| """Restart the RPC server. | ||
|
|
||
| Args: | ||
| resync_rh (bool): Whether to resync runhouse. (Default: ``True``) | ||
| resync_rh (bool): Whether to resync runhouse. Specifying False will not sync Runhouse under any circumstance. If it is None, then it will sync if Runhouse is not installed on the cluster or if locally it is installed as editable. (Default: ``None``) |
There was a problem hiding this comment.
I think we don't need to specify the behavior for False or True, should be pretty self explanatory.
Suggested change
| resync_rh (bool): Whether to resync runhouse. Specifying False will not sync Runhouse under any circumstance. If it is None, then it will sync if Runhouse is not installed on the cluster or if locally it is installed as editable. (Default: ``None``) | |
| resync_rh (bool): Whether to resync runhouse. By default, it will sync if Runhouse is not installed on the cluster or if locally it is installed as editable. (Default: ``None``) |
Comment on lines
433
to
438
| local_ray_version_call = subprocess.run( | ||
| ["pip freeze | grep ray"], | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, | ||
| shell=True, | ||
| ) |
There was a problem hiding this comment.
Do you have an existing helper from the new package functionality to grab the local version for a package? Better not to have to handle edge cases here like editable / local installs.
rohinb2
force-pushed
the
07-16-Sync_runhouse_before_installing_default_env_
branch
from
dcec26c to
0531ebc
Compare
rohinb2
force-pushed
the
07-16-Change_resync_rh_to_False_by_default
branch
from
3ff0ef9 to
790f5bb
Compare
rohinb2
force-pushed
the
07-16-Sync_runhouse_before_installing_default_env_
branch
from
0531ebc to
c75b4db
Compare
Base automatically changed from
07-16-Sync_runhouse_before_installing_default_env_
to
main
July 17, 2024 15:06
rohinb2
force-pushed
the
07-16-Change_resync_rh_to_False_by_default
branch
from
790f5bb to
3499ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic is now as follows.
resync_rhisNoneby default. In this case or ifresync_rhis just set toTrue:If
resync_rhis False, then we for sure do not sync Runhouse in any way.