Update cluster client flow #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
carolineechen
force-pushed
the
cc/client-update
branch
2 times, most recently
from
a9bcd99 to
f5cfe6c
Compare
carolineechen
force-pushed
the
cc/client-update
branch
from
f5cfe6c to
cbf738f
Compare
dongreenberg
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move
check_serverinto the client construction to avoid extra calls when making every client call. also removerestart_serverwhen there are connection errors, as this wipes the entire runhouse state on the cluster. instead, reset and try to reconnect the client and throw an error if that still doesn't work.