Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI RAG app example with vector embeddings #1118

Merged
merged 10 commits into from
Aug 12, 2024
Merged

Conversation

mkandler
Copy link
Contributor

@mkandler mkandler commented Aug 6, 2024

No description provided.

@mkandler mkandler marked this pull request as ready for review August 9, 2024 21:55
@mkandler mkandler changed the title [WIP] Fastapi embedding example FastAPI RAG app example with vector embeddings Aug 9, 2024

module_name = "llama_model"
# First check for an instance of the LlamaModel stored on the cluster
remote_llm = cluster.get(module_name, default=None, remote=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this block here to remove confusion behind get_or_to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah and I think .get_or_to isn't necessarily working as intended for modules? @dongreenberg made this point last week

@mkandler mkandler merged commit c75fa7c into main Aug 12, 2024
10 of 12 checks passed
@mkandler mkandler deleted the fastapi-embedding-example branch August 12, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants